Changeset 2436 for trunk/packages/invirt-remote/host/usr/sbin/invirt-lvm

Timestamp:

Aug 11, 2009, 10:38:42 PM (15 years ago)

Author:

broder

Message:

In invirt-remote:

• Instead of running all of the disk-wiping dds simultaneously, run them sequentially using a janitor daemon (LP: #411486).

File:

• trunk/packages/invirt-remote/host/usr/sbin/invirt-lvm (modified) (1 diff)

trunk/packages/invirt-remote/host/usr/sbin/invirt-lvm

@@ -64 +64 @@
     ensureoff(machine)
     
-    # Fork. The child process wipes the LV and then deletes
-    # it. There's not really anything sane to do with errors (since
-    # this is running non-interactively), so let's just drop them on
-    # the floor for now.
-    if os.fork() == 0:
-        call(["/usr/bin/ionice", "-c", "2", "-n", "7", "/bin/dd", "if=/dev/zero", "of=%s" % new_lvpath])
-        call(["/sbin/lvchange", "-a", "n", new_lvpath])
-        call(["/sbin/lvchange", "-a", "ey", new_lvpath])
-        call(["/sbin/lvremove", "--force", new_lvpath])
+    # Touch a file corresponding to the new name of the LV; a separate
+    # daemon will handle wiping and deleting it.
+    open(os.path.join('/var/lib/invirt-remote/cleanup', new_lvname), 'w')
 elif subcommand == "lvresize":
     size = sys.argv[4]