Changeset 2400

Timestamp:

Aug 9, 2009, 6:45:28 PM (15 years ago)

Author:

quentin

Message:

Move the help popup code into the templates where it belongs

Location:

package_branches/invirt-web/cherrypy/code

Files:

• main.py (modified) (2 diffs)
• templates/functions.mako (modified) (1 diff)

package_branches/invirt-web/cherrypy/code/main.py

@@ -94 +94 @@
 checkpoint = Checkpoint()
 
-def jquote(string):
-    return "'" + string.replace('\\', '\\\\').replace("'", "\\'").replace('\n', '\\n') + "'"
-
-def helppopup(subj):
-    """Return HTML code for a (?) link to a specified help topic"""
-    return ('<span class="helplink"><a href="help?' +
-            cgi.escape(urllib.urlencode(dict(subject=subj, simple='true')))
-            +'" target="_blank" ' +
-            'onclick="return helppopup(' + cgi.escape(jquote(subj)) + ')">(?)</a></span>')
-
 def makeErrorPre(old, addition):
     if addition is None:
@@ -114 +104 @@
 Template.database = database
 Template.config = config
-Template.helppopup = staticmethod(helppopup)
 Template.err = None
 

package_branches/invirt-web/cherrypy/code/templates/functions.mako

@@ -39 +39 @@
 % endif
 </%def>
+
+<%!
+def jquote(string):
+    return "'" + string.replace('\\', '\\\\').replace("'", "\\'").replace('\n', '\\n') + "'"
+%>
+
+<%def name="helppopup(subj)">
+## Return HTML code for a (?) link to a specified help topic
+<span class="helplink"><a href="help?simple=true;subject=${subj | u}" target="_blank" onclick="return helppopup(${subj | jquote,u})">(?)</a></span>
+</%def>