Changeset 874

Timestamp:

Aug 6, 2008, 1:07:22 AM (16 years ago)

Author:

price

Message:

add and respect 'adminable' column to machines

This is for selectively, temporarily, manually enabling admin mode
for a VM. Where it's not set, admin mode now bypasses quotas and does
nothing else.

Location:

trunk/packages

Files:

• sipb-xen-database/debian/changelog (modified) (1 diff)
• sipb-xen-database/python/database/models.py (modified) (2 diffs)
• sipb-xen-www/code/validation.py (modified) (1 diff)
• sipb-xen-www/code/webcommon.py (modified) (2 diffs)

trunk/packages/sipb-xen-database/debian/changelog

@@ +1 @@
+sipb-xen-database (10.18) unstable; urgency=low
+
+  * add 'adminable' column to machines; for selectively, temporarily,
+    enabling admin mode on a machine
+
+ -- Greg Price <price@mit.edu>  Wed,  6 Aug 2008 01:02:59 -0400
+
 sipb-xen-database (10.17) unstable; urgency=low
 

trunk/packages/sipb-xen-database/python/database/models.py

@@ -21 +21 @@
            'CDROM',
            'Autoinstall',
+           'or_',
            ]
 
@@ -37 +38 @@
        Column('type_id', String, ForeignKey('types.type_id'), nullable=False),
        Column('autorestart', Boolean, nullable=False, default=False),
-       Column('cpus', Integer, nullable=False, default=1))
+       Column('cpus', Integer, nullable=False, default=1),
+       Column('adminable', Boolean, nullable=False, default=False))
 
 nic_table = Table('nics', meta,

trunk/packages/sipb-xen-www/code/validation.py

@@ -126 +126 @@
 def haveAccess(user, state, machine):
     """Return whether a user has administrative access to a machine"""
-    return state.isadmin or user in cache_acls.accessList(machine)
+    return (user in cache_acls.accessList(machine)
+            or (machine.adminable and state.isadmin))
 
 def owns(user, machine):

trunk/packages/sipb-xen-www/code/webcommon.py

@@ -2 +2 @@
 
 import time
+from invirt import database
 from invirt.database import Machine, MachineAccess
 
@@ -45 +46 @@
     def getMachines(self):
         if self.isadmin:
-            return Machine.select()
+            return Machine.query().join('acl').select_by(
+                database.or_(MachineAccess.c.user == self.username,
+                             Machine.c.adminable == True))
         else:
             return Machine.query().join('acl').select_by(user=self.username)