Changeset 651 for trunk

Timestamp:

Jun 23, 2008, 10:10:52 PM (16 years ago)

Author:

broder

Message:

Restructuring code to correctly return NXDOMAIN on non-A-record requests

File:

• trunk/packages/sipb-xen-dns/code/dnsserver.py (modified) (2 diffs)

trunk/packages/sipb-xen-dns/code/dnsserver.py

@@ -65 +65 @@
                                       3600, self.ns, auth=True))
         if cls == dns.IN:
-            if type in (dns.A, dns.ALL_RECORDS):
-                host = name[:-len(domain)-1]
-                if not host:
+            host = name[:-len(domain)-1]
+            if not host:
+                if type in (dns.A, dns.ALL_RECORDS):
                     record = dns.Record_A('18.181.0.62', ttl)
                     results.append(dns.RRHeader(name, dns.A, dns.IN, 
                                                 ttl, record, auth=True))
-                else:
+                elif type == dns.NS:
+                    results.append(dns.RRHeader(domain, dns.NS, dns.IN,
+                                                ttl, self.ns, auth=True))
+                    authority = []
+                elif type == dns.SOA:
+                    results.append(dns.RRHeader(domain, dns.SOA, dns.IN,
+                                                ttl, self.soa, auth=True))
+            else:
+                if host:
                     value = sipb_xen_database.Machine.get_by(name=host)
                     if value is None or not value.nics:
@@ -78 +86 @@
                     if ip is None:  #Deactivated?
                         return defer.fail(failure.Failure(dns.AuthoritativeDomainError(name)))
+                if type in (dns.A, dns.ALL_RECORDS):
                     record = dns.Record_A(ip, ttl)
                     results.append(dns.RRHeader(name, dns.A, dns.IN, 
                                                 ttl, record, auth=True))
-            elif type == dns.NS:
-                results.append(dns.RRHeader(domain, dns.NS, dns.IN,
-                                            ttl, self.ns, auth=True))
-                authority = []
-            elif type == dns.SOA:
-                results.append(dns.RRHeader(domain, dns.SOA, dns.IN,
-                                            ttl, self.soa, auth=True))
+                elif type == dns.SOA:
+                    results.append(dns.RRHeader(domain, dns.SOA, dns.IN,
+                                                ttl, self.soa, auth=True))
             if len(results) == 0:
                 authority = []