Changeset 599

Timestamp:

Jun 13, 2008, 2:58:13 AM (17 years ago)

Author:

price

Message:

send mail on all exceptions

Location:

trunk/packages/sipb-xen-www/code

Files:

• main.py (modified) (3 diffs)
• templates/error.tmpl (modified) (1 diff)

trunk/packages/sipb-xen-www/code/main.py

@@ -18 +18 @@
     errio = sys.stderr
     if not isinstance(errio, StringIO):
-        return None
+        return ''
     sys.stderr = sys.stdout
     errio.seek(0)
@@ -121 +121 @@
 def error(op, username, fields, err, emsg):
     """Print an error page when a CodeError occurs"""
+    send_error_mail('xvm error on %s for %s: %s' % (op, username, err),
+                    'error on %s for %s: %s\n\n%s\n'
+                    % (op, username, err, emsg))
     d = dict(op=op, user=username, errorMessage=str(err),
              stderr=emsg)
@@ -582 +585 @@
 def throwError(_, __, ___):
     """Throw an error, to test the error-tracing mechanisms."""
-    raise RuntimeError("This is a test of the emergency broadcast system.")
+    raise CodeError("test of the emergency broadcast system")
 
 mapping = dict(list=listVms,

trunk/packages/sipb-xen-www/code/templates/error.tmpl

@@ -7 +7 @@
 
 #def body
-<p>$errorMessage in operation $op.  This shouldn't happen!  Please
-email xvm@mit.edu to explain how it happened.  Stderr:</p>
-<pre>$stderr</pre>
+<p>Uh-oh!  We experienced an error.  Sorry about that.  We've gotten
+mail about it.</p>
+
+<p>Feel free to poke us at <tt>xvm@mit.edu</tt> if this bug is
+consistently biting you and we don't seem to be fixing it.</p>
+
+<p>In case you're curious, the gory details are here.</p>
+
+<pre>
+Error on operation $op for user $user: $errorMessage
+Error output (if any):
+$stderr
+</pre>
 #end def