Changeset 2093 for trunk/packages/invirt-remote/host/usr

Timestamp:

Feb 5, 2009, 3:19:21 AM (16 years ago)

Author:

broder

Message:

Don't pass untrusted arguments to xm info.

Location:

trunk/packages/invirt-remote/host/usr/sbin

Files:

• invirt-remote (modified) (2 diffs)
• invirt-vmcontrol (modified) (1 diff)

trunk/packages/invirt-remote/host/usr/sbin/invirt-remote

@@ -22 +22 @@
                 ;;
             info)
-                COMMAND=/usr/sbin/xm
+                exec /usr/sbin/xm info
                 ;;
             vnccert)
@@ -39 +39 @@
 esac
 
-$COMMAND "$SERVICE" "$@"
+exec "$COMMAND" "$SERVICE" "$@"

trunk/packages/invirt-remote/host/usr/sbin/invirt-vmcontrol

@@ -12 +12 @@
 ACTION="$2"
 MACHINE="d_$ORIGMACHINE"
+
+xm () {
+    command xm "$@" || exit 35
+}
 
 case "$ACTION" in