Changeset 1163 for trunk/packages/sipb-xen-remote-server

Timestamp:

Oct 22, 2008, 12:48:44 AM (16 years ago)

Author:

broder

Message:

There's a race condition for if the VM gets powered off between the
listvms and the actual request. Solve the problem correctly by using a
non-conflicting error code to indicate an invalid command

Location:

trunk/packages/sipb-xen-remote-server

Files:

• debian/changelog (modified) (1 diff)
• files/usr/sbin/sipb-xen-remote-control (modified) (1 diff)

trunk/packages/sipb-xen-remote-server/debian/changelog

@@ +1 @@
+sipb-xen-remote-server (0.10.2) unstable; urgency=low
+
+  * There's a race condition for if the VM gets powered off between the
+    listvms and the actual request. Solve the problem correctly by using a
+    non-conflicting error code to indicate an invalid command
+
+ -- Evan Broder <broder@mit.edu>  Wed, 22 Oct 2008 00:46:38 -0400
+
 sipb-xen-remote-server (0.10.1) unstable; urgency=low
 

trunk/packages/sipb-xen-remote-server/files/usr/sbin/sipb-xen-remote-control

@@ -31 +31 @@
     (out, err) = p.communicate()
     if p.returncode == 1:
+        print >>sys.stderr, "machine '%s' is not on" % machine_name
+        return 1
+    elif p.returncode == 34:
         print >>sys.stderr, "ERROR: invalid command"
-        return 1
+        return 34
     sys.stderr.write(err)
     sys.stdout.write(out)