Changeset 2093

Timestamp:

Feb 5, 2009, 3:19:21 AM (15 years ago)

Author:

broder

Message:

Don't pass untrusted arguments to xm info.

Location:

trunk/packages/invirt-remote

Files:

• debian/changelog (modified) (1 diff)
• host/usr/sbin/invirt-remote (modified) (2 diffs)
• host/usr/sbin/invirt-vmcontrol (modified) (1 diff)

trunk/packages/invirt-remote/debian/changelog

@@ +1 @@
+invirt-remote (0.3.2) unstable; urgency=low
+
+  * Don't pass untrusted arguments to xm info.
+  * Exit with a non-0 error code on the host if there's an error.
+
+ -- Evan Broder <broder@mit.edu>  Sat, 31 Jan 2009 03:51:24 -0500
+
 invirt-remote (0.3.1) unstable; urgency=low
 

trunk/packages/invirt-remote/host/usr/sbin/invirt-remote

@@ -22 +22 @@
                 ;;
             info)
-                COMMAND=/usr/sbin/xm
+                exec /usr/sbin/xm info
                 ;;
             vnccert)
@@ -39 +39 @@
 esac
 
-$COMMAND "$SERVICE" "$@"
+exec "$COMMAND" "$SERVICE" "$@"

trunk/packages/invirt-remote/host/usr/sbin/invirt-vmcontrol

@@ -12 +12 @@
 ACTION="$2"
 MACHINE="d_$ORIGMACHINE"
+
+xm () {
+    command xm "$@" || exit 35
+}
 
 case "$ACTION" in